Skip to content

[chore](fe) remove redundant test dependencies#61294

Open
CalvinKirs wants to merge 1 commit intoapache:masterfrom
CalvinKirs:codex/redundant-deps-audit
Open

[chore](fe) remove redundant test dependencies#61294
CalvinKirs wants to merge 1 commit intoapache:masterfrom
CalvinKirs:codex/redundant-deps-audit

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Mar 13, 2026 •
edited
Loading

What

This PR removes several redundant FE-side test dependencies.

Why

A quick dependency audit under fe/ found a few dependencies that are declared but not actually used:

  • hamcrest in multiple FE modules
  • JUnit 5 test dependencies in fe-extension-loader, which currently has no test sources

Keeping these unused dependencies increases dependency surface and maintenance cost without bringing value.

@CalvinKirs CalvinKirs requested a review from morningman as a code owner March 13, 2026 02:21
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 13, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Mar 13, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Mar 13, 2026

TPC-H: Total hot run time: 27655 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f45b815adcf9401c0edf697e853d98b0a8df857b, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17626	4496	4290	4290
q2	q3	10649	801	516	516
q4	4673	362	259	259
q5	7566	1213	1019	1019
q6	177	178	147	147
q7	807	839	673	673
q8	9742	1472	1329	1329
q9	5246	4748	4689	4689
q10	6327	1909	1649	1649
q11	461	259	244	244
q12	743	570	482	482
q13	18042	2894	2190	2190
q14	236	223	224	223
q15	926	802	830	802
q16	761	715	702	702
q17	709	857	415	415
q18	6218	5493	5270	5270
q19	1110	977	609	609
q20	499	486	392	392
q21	4573	2121	1482	1482
q22	408	328	273	273
Total cold run time: 97499 ms
Total hot run time: 27655 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4684	4562	4585	4562
q2	q3	3849	4411	3847	3847
q4	867	1219	822	822
q5	4086	4348	4327	4327
q6	179	180	146	146
q7	1740	1651	1539	1539
q8	2474	2761	2552	2552
q9	7578	7455	7379	7379
q10	3710	3977	3598	3598
q11	525	450	411	411
q12	475	601	465	465
q13	2770	3427	2333	2333
q14	318	327	298	298
q15	866	842	801	801
q16	709	756	747	747
q17	1173	1427	1324	1324
q18	7119	6793	6593	6593
q19	895	902	939	902
q20	2089	2167	2054	2054
q21	3908	3468	3357	3357
q22	458	448	372	372
Total cold run time: 50472 ms
Total hot run time: 48429 ms

@doris-robot
Copy link

doris-robot commented Mar 13, 2026

TPC-DS: Total hot run time: 152986 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f45b815adcf9401c0edf697e853d98b0a8df857b, data reload: false

query5	4328	637	530	530
query6	331	239	206	206
query7	4235	480	270	270
query8	345	249	242	242
query9	8668	2695	2664	2664
query10	497	406	338	338
query11	7358	5877	5648	5648
query12	184	136	125	125
query13	1277	444	373	373
query14	5764	3868	3583	3583
query14_1	2792	2832	2804	2804
query15	208	200	177	177
query16	1009	469	457	457
query17	1108	734	630	630
query18	2440	452	358	358
query19	224	210	184	184
query20	135	137	131	131
query21	222	145	128	128
query22	4886	4948	4730	4730
query23	16779	16075	15912	15912
query23_1	15927	16174	15841	15841
query24	8262	1734	1292	1292
query24_1	1344	1334	1314	1314
query25	599	525	486	486
query26	1296	298	166	166
query27	3161	491	311	311
query28	4514	1862	1840	1840
query29	830	554	474	474
query30	314	242	210	210
query31	1362	1286	1218	1218
query32	89	72	75	72
query33	507	321	290	290
query34	918	935	569	569
query35	664	689	604	604
query36	1104	1104	1002	1002
query37	134	93	83	83
query38	3009	2909	2846	2846
query39	877	854	846	846
query39_1	827	859	829	829
query40	229	149	137	137
query41	61	63	59	59
query42	310	303	302	302
query43	243	248	227	227
query44	
query45	203	211	190	190
query46	891	993	609	609
query47	2122	2149	2075	2075
query48	338	333	251	251
query49	651	469	397	397
query50	708	303	244	244
query51	4260	4213	4096	4096
query52	301	297	290	290
query53	303	345	290	290
query54	305	270	259	259
query55	94	83	87	83
query56	320	305	287	287
query57	1371	1359	1324	1324
query58	295	275	295	275
query59	1282	1461	1295	1295
query60	327	340	329	329
query61	151	147	142	142
query62	629	591	545	545
query63	317	275	273	273
query64	5057	1287	1023	1023
query65	
query66	1461	455	349	349
query67	16356	16509	16121	16121
query68	
query69	391	307	285	285
query70	1032	1078	931	931
query71	338	311	301	301
query72	2903	2645	1968	1968
query73	550	553	339	339
query74	9964	9966	9806	9806
query75	2858	2795	2459	2459
query76	2281	1015	680	680
query77	357	376	300	300
query78	11164	11367	10681	10681
query79	3010	841	599	599
query80	1703	618	547	547
query81	571	269	245	245
query82	967	151	117	117
query83	334	267	239	239
query84	256	112	100	100
query85	896	480	428	428
query86	408	342	302	302
query87	3125	3099	3053	3053
query88	3585	2673	2648	2648
query89	424	369	343	343
query90	1967	182	178	178
query91	163	165	136	136
query92	75	78	71	71
query93	1208	834	515	515
query94	647	326	297	297
query95	589	337	376	337
query96	650	517	231	231
query97	2519	2477	2427	2427
query98	235	210	215	210
query99	1020	988	905	905
Total cold run time: 238193 ms
Total hot run time: 152986 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman Awaiting requested review from morningman morningman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dev/3.1.x dev/4.0.x dev/4.1.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CalvinKirs @hello-stephen @doris-robot